Add reproduction for String issue - #6860
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8301075 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — a single reproduction test for String.noCase ignoring its splitRegExp option.
- Reproduction test: adds
it("uses a custom split regular expression")in thenoCasedescribe block, asserting that a customsplitRegExpis respected.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
tim-smart
enabled auto-merge (squash)
August 2, 2026 23:28
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — implementation fix for String.noCase honoring custom regexp options, building on the reproduction test from the prior review.
- Honor
splitRegExpandstripRegExpinnoCase: resolves options via newtoRegExpArrayhelper that normalizesRegExp | ReadonlyArray<RegExp>toReadonlyArray<RegExp>, then passes them tonormalizeCase. - Unify
stripRegExphandling innormalizeCase: changed the parameter type fromRegExptoReadonlyArray<RegExp>and replaced the single.replacewith a loop, mirroring the existingsplitRegExppattern. - Update
configCasecall site: wrapsSTRIP_REGEXPin an array to match the new parameter type. - Expand test coverage: 4 new test cases for single/array
splitRegExpand single/arraystripRegExp.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String.noCasetokenization options.splitRegExpandstripRegExpvalues, including arrays of regular expressions.effect.Reproduction
Closes EFF-317